Feature | AKV Provider Upgrade to use new Azure key Vault libraries #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
David-Engel,
karinazhou,
JRahnama,
DavoudEshtehari and
johnnypham
cheenamalhotra
added
🆕 Public API
Xtrimmer
reviewed
Jul 7, 2020
...crosoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureKeyVaultProviderTokenCredential.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureKeyVaultProviderTokenCredential.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/AKVUnitTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Show resolved
Hide resolved
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Outdated
Show resolved
Hide resolved
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Outdated
Show resolved
Hide resolved
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Outdated
Show resolved
Hide resolved
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Show resolved
Hide resolved
heaths
reviewed
Jul 9, 2020
There was a problem hiding this comment.
I only reviewed the production code using Key Vault packages directly and overall it looks okay, but I'm curious why it's all implemented synchronously? Where necessary, you're calling async over sync (and in some places, in ways that can deadlock) but wouldn't it make for a more efficient package for callers to use async?
...crosoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureKeyVaultProviderTokenCredential.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureKeyVaultProviderTokenCredential.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureKeyVaultProviderTokenCredential.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureKeyVaultProviderTokenCredential.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureKeyVaultProviderTokenCredential.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
|
I believe the reason of synchronous methods only is the class |
Xtrimmer
approved these changes
Aug 7, 2020
David-Engel
reviewed
Aug 26, 2020
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/AKVUnitTests.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props # src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/Setup/ColumnMasterKey.cs # src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
Enclave example code and updating some public API comments
Update tests
johnnypham
approved these changes
Feb 10, 2021
JRahnama
reviewed
Feb 26, 2021
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AzureSqlKeyCryptographer.cs
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
Feb 26, 2021
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Outdated
Show resolved
Hide resolved
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/AKVUnitTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Javad <[email protected]> Co-authored-by: David Engel <[email protected]>
JRahnama
approved these changes
Feb 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #294
Changes full design and introduces new constructors to accept implementation of
TokenCredentialto support new libraries.Breaking Changes:
cc @Xtrimmer
[6 Aug, 2020] Update:
The old constructors are now removed totally and driver does not implement/support authentication callback in new design now. For user applications willing to support multi-user credentials for acquiring tokens, can implement a custom TokenCredential class with their own logic in "GetToken" and "GetTokenAsync" APIs. An example has been added (doc/samples/AzureKeyVaultProviderLegacyExample_2_0.cs) to the repository to demonstrate the same, will be published to Microsoft Docs.