-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/installer #7255
Merged
jonathanpeppers
merged 14 commits into
main
from
darc-main-5239d12a-fa8e-406c-828a-c43e5bdac23e
Aug 18, 2022
Merged
[main] Update dependencies from dotnet/installer #7255
jonathanpeppers
merged 14 commits into
main
from
darc-main-5239d12a-fa8e-406c-828a-c43e5bdac23e
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…220812.1 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22409.23 -> To Version 7.0.100-rc.1.22412.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22411.2 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro
bot
requested review from
jonathanpeppers,
pjcollins and
jonpryor
as code owners
August 12, 2022 13:57
This reverts commit eefe470.
This reverts commit 3f3c9c0.
Context: dotnet/runtime#71203 Fixes: #7249 Apps on this PR currently crash with: mono-rt : [ERROR] FATAL UNHANDLED EXCEPTION: System.InvalidProgramException: Invalid IL code in (wrapper managed-to-native) object:wrapper_native_0x7725af156f10 (intptr): IL_0012: calli 0x00000003 mono-rt : at System.Runtime.InteropServices.Marshal.PtrToStructureHelper(IntPtr , Object , Boolean ) mono-rt : at System.Runtime.InteropServices.Marshal.PtrToStructure(IntPtr , Type ) mono-rt : at Java.Interop.JniRuntime.CreateInvoker(IntPtr ) mono-rt : at Java.Interop.JniRuntime..ctor(CreationOptions ) mono-rt : at Android.Runtime.AndroidRuntime..ctor(IntPtr , IntPtr , Boolean , IntPtr , IntPtr , Boolean ) mono-rt : at Android.Runtime.JNIEnv.Initialize(JnienvInitializeArgs* ) Which, I assume is due to a missing Mono component. We should add the component by default: <_MonoComponent Condition=" '$(_IncludeMarshalIlGen)' != 'false' " Include="marshal-ilgen" /> In the future, someone could experiment by setting `$(_IncludeMarshalIlGen)` to `false`.
jonathanpeppers
force-pushed
the
darc-main-5239d12a-fa8e-406c-828a-c43e5bdac23e
branch
from
August 15, 2022 03:04
96acf95
to
303f41f
Compare
…220814.7 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22409.23 -> To Version 7.0.100-rc.1.22414.7 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22412.1 (parent: Microsoft.Dotnet.Sdk.Internal
Context: dotnet/linker#2929 Context: https://github.com/dotnet/linker/blob/6e8e139a484f74c524c821c7a4a08287d77257a4/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets#L227-L229 Fixes: #7256 Serialization heuristics in the .NET 7 linker is now opt-in. We now need to pass a new flag to the linker by default: <_ExtraTrimmerArgs>--enable-serialization-discovery $(_ExtraTrimmerArgs)</_ExtraTrimmerArgs> This might also solve project builds in `Release` mode that appear to hang: Task "ILLink" (TaskId:272) Builds appear to be running this task and never exit. Let's hope this also solves this?
This reverts commit 740e5e1.
…220817.1 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22409.23 -> To Version 7.0.100-rc.2.22417.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22415.4 (parent: Microsoft.Dotnet.Sdk.Internal
Ok, wow one test hit:
This test is the one that builds an app with 100 class libraries. Let me rerun & potentially file an issue. We can also disable this test for now. |
This passed on rerun: #7255 (comment) I'll keep an eye on it and file an issue if we need to. |
jonathanpeppers
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jonathanpeppers
deleted the
darc-main-5239d12a-fa8e-406c-828a-c43e5bdac23e
branch
August 18, 2022 18:27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer