Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 7 RC 1, illink is up to 10x slower? #2975

Closed
jonathanpeppers opened this issue Aug 15, 2022 · 9 comments
Closed

.NET 7 RC 1, illink is up to 10x slower? #2975

jonathanpeppers opened this issue Aug 15, 2022 · 9 comments

Comments

@jonathanpeppers
Copy link
Member

This started happening here:

Many of our test lanes that generate projects and build them seem to be timing out.

From what I see so far, the log ends with:

Task "ILLink" (TaskId:268)
... all the input parameters here
(TaskId:268)

And then the msbuild.binlog is broken because the build was canceled after a timeout. So I believe the last task that ran is ILLink?

logs.zip

I think this is happening with any Release build of an Android project, but I will do more investigation locally.

@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Aug 15, 2022

Ok, maybe we are timing out because the duration has now increased significantly:

image

Then this is x4 for 4 RIDs.

In .NET 6:

image

net6vsnet7.zip

If our integration tests build lots of projects, maybe we are now just hitting general timeouts?

jonathanpeppers added a commit to dotnet/android that referenced this issue Aug 15, 2022
@jonathanpeppers jonathanpeppers changed the title .NET 7 RC 1, illink never exits? .NET 7 RC 1, illink is up to 10x slower? Aug 15, 2022
@sbomer
Copy link
Member

sbomer commented Aug 15, 2022

@jtschuster would you be able to investigate?

@SteveMCarroll
Copy link

fyi, this is on our critical path for RC1. thanks.

@sbomer
Copy link
Member

sbomer commented Aug 15, 2022

@jonathanpeppers would you be able to share a repro? We haven't been able to measure any regression so far (we measured time taken to trim the framework while rooting everything), and nothing jumps out immediately from that commit range.

@jonathanpeppers
Copy link
Member Author

To repro I did dotnet new android and dotnet build -c Release, using a local build of xamarin/xamarin-android.

I tried using xamarin-android/main instead of dotnet/android#7255.

This seems to be faster:

image

net7-older.zip

This makes me think there was a ~1 second regression from 6 to 7 (might actually be fine?).

But then a larger regression in here somewhere: f09bacf...95ea184

@jtschuster
Copy link
Member

Fix is in #2976.

@sbomer
Copy link
Member

sbomer commented Aug 22, 2022

Fixed in #2976

@sbomer sbomer closed this as completed Aug 22, 2022
@jonathanpeppers
Copy link
Member Author

@sbomer the only thing we should double-check. Is this fix in .NET 7 RC1?

I just want to make sure we won't be blocked when we go to test our release branches.

@sbomer
Copy link
Member

sbomer commented Aug 22, 2022

It has made it into the sdk's RC1 branch: dotnet/sdk#27219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants