-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning #8173
Conversation
…t as FabricBot replacement Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html Please review and merge this PR to complete the process of onboarding to the new service.
@jpobst does it look like we "lost any" rules? I have an email saying this new service might be missing a few features -- so I wonder if we lose anything? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,109 @@ | |||
id: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpobst: this feels "weird"/"wrong" to me.
First, it's an empty value for "id", which just feels weird. Secondly, none of the examples use id:
at all, e.g. https://microsoft.github.io/GitOps/policies/examples/pr-triage.html
Should we remove id:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what the creators of the service are proposing. I think we should defer to them that they know what is best. 😁
@@ -0,0 +1,109 @@ | |||
id: | |||
name: GitOps.PullRequestIssueManagement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we provide a better name:
value?
WIP commit message: Context: fb89198f7f9a583c546fb02cce5c9be78402bf20
Context: a0377cdae565e361100b891fe171a5aa49778207
Context: 39183370b98b3afaa0211c8c61de923bde537941
Context: https://microsoft.github.io/GitOps/policies/resource-management.html
Migrate away from `fabricbot.json` (fb89198f, a0377cda, 39183370) to
`.github/policies/resourceManagement.yml`
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> |
Action RequiredOn August 8, Fabric Bot will be turned off and Issues and PR's in this repository will stop receiving the automations it provides. Merging this PR prior to that date will ensure that the automations you have configured will continue without interruption. Please review and merge this PR as soon as possible. See aka.ms/gim/fabricbot for more information |
Context: 16e0943 Context: dotnet/maui#19145 When we migrated from FabricBot to GitOps.ResourceManagement due to FabricBot being decommissioned (16e0943), we lost the rule: * [Closed Issue Management] Lock issues closed without activity for over 30 days This rule is useful because comments on old, closed issues rarely will be seen or responded to, making us seem unresponsive to users. MAUI has replaced this rule (dotnet/maui#19145) with a GitHub Action written by the VSCode team that runs daily and performs the locking. We should ~~steal~~ borrow this for our own repos. [0]: #8173
Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement
Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html
Please review and merge this PR to complete the process of onboarding to the new service.