Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.github] Re-enable locking closed issues after 30 days of inactivity. #8655

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jan 19, 2024

Context: #8173
Context: dotnet/maui#19145

When we accepted migration from FabricBot to GitOps.ResourceManagement due to FabricBot being decommissioned, one rule we lost was [Closed Issue Management] Lock issues closed without activity for over 30 days. This rule is useful because comments on old, closed issues rarely will be seen or responded to, making us seem unresponsive to users.

MAUI has replaced this rule with a GitHub action written by the VSCode team that runs daily and performs the locking. We should steal borrow this for our own.

Unfortunately I'm not aware of a way to test a GitHub Action without it already being in main, so this is untested. 😦

@jpobst jpobst changed the title [.github] Re-enable locking issues after 30 days of inactivity. [.github] Re-enable locking closed issues after 30 days of inactivity. Jan 19, 2024
@jpobst jpobst marked this pull request as ready for review January 19, 2024 20:06
@jpobst jpobst requested a review from jonpryor as a code owner January 19, 2024 20:06
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Jeff's original PR (dotnet/maui#19145) he says:

Since this workflow uses the actions/checkout action, we need to ensure the following GitHub Actions settings are enabled:

Allow enterprise, and select non-enterprise, actions and reusable workflows
Allow actions created by GitHub

Do we need to do that before merging?

@jpobst
Copy link
Contributor Author

jpobst commented Jan 19, 2024

Do we need to do that before merging?

I can't see the repository settings for XA, but our existing workflow also uses actions/checkout, so I'm guessing we have the correct settings already:

https://github.com/xamarin/xamarin-android/blob/eda5449e4eb7a637ca3caa3b87022bfa671156f8/.github/workflows/sdk-insertion-bump.yml#L15

If the settings are incorrect, it will simply error when it tries to run, no harm done.

@jonpryor jonpryor merged commit 9028e22 into main Jan 22, 2024
45 of 47 checks passed
@jonpryor jonpryor deleted the install-issue-locker branch January 22, 2024 20:24
grendello added a commit that referenced this pull request Jan 22, 2024
* main:
  [.github] Re-enable locking issues after 30 days of inactivity (#8655)
  Localized file check-in by OneLocBuild Task (#8657)
grendello added a commit that referenced this pull request Jan 25, 2024
* main:
  Localized file check-in by OneLocBuild Task (#8668)
  [Xamarin.Android.build.Tasks] `<CheckDuplicateJavaLibraries/>` ignores `repackaged.jar` (#8664)
  LEGO: Merge pull request 8665
  [Xamarin.Android.Build.Tasks] parse JDK `release` file directly (#8663)
  Bump to dotnet/installer@f91d4ca399 9.0.100-alpha.1.24070.3 (#8635)
  [.github] Re-enable locking issues after 30 days of inactivity (#8655)
  Localized file check-in by OneLocBuild Task (#8657)
  LEGO: Merge pull request 8656
  Localized file check-in by OneLocBuild Task (#8652)
  Bump to xamarin/xamarin-android-tools/main@b175674 (#8644)
  [Xamarin.Android.Build.Tasks] remove checks for `$(UsingAndroidNETSdk)` (#8647)
  [Xamarin.Android.Build.Tasks] XA1039 error for Android.Support (#8629)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants