Skip to content

Commit

Permalink
Switch filter condition from BuildAllConfigurations to BuildTargetFra…
Browse files Browse the repository at this point in the history
…mework (#5575)

With dotnet/runtime#35606, we will be able to build for all configurations by default on individual projects hence it doesn't make sense anymore to condition on the `BuildAllConfigurations` property for filtering in the TargetFramework.Sdk. Instead conditioning on `BuildTargetFramework`.
  • Loading branch information
ViktorHofer committed Jul 21, 2020
1 parent 08c6abc commit fecc321
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</Target>

<Target Name="RunOnlyBestTargetFrameworks"
Condition="'$(BuildAllConfigurations)' != 'true' or '$(MSBuildProjectExtension)' == '.pkgproj'"
Condition="'$(BuildTargetFramework)' != '' or '$(MSBuildProjectExtension)' == '.pkgproj'"
BeforeTargets="DispatchToInnerBuilds"
DependsOnTargets="GetProjectWithBestTargetFrameworks">
<ItemGroup>
Expand Down

0 comments on commit fecc321

Please sign in to comment.