Switch filter condition from BuildAllConfigurations to BuildTargetFramework #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mework With dotnet/runtime#35606, we will be able to build for all configurations by default on individual projects hence it doesn't make sense anymore to condition on the `BuildAllConfigurations` property for filtering in the TargetFramework.Sdk. Instead conditioning on `BuildTargetFramework`.
Anipik
approved these changes
May 29, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dotnet/runtime#35606, we will be able to build for all configurations by default on individual projects hence it doesn't make sense anymore to condition on the
BuildAllConfigurationsproperty for filtering in the TargetFramework.Sdk. Instead conditioning onBuildTargetFramework.No merge before the runtime PR is merged.