add System.IO.Packaging to Version.Details #13754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
Jun 2, 2023
MichaelSimons
approved these changes
Jun 2, 2023
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3043
Declaring the
System.IO.Packagingdependency inVersion.Details.xmlwill allow source-build to replace the currently used7.0.0version with then-1version coming from previously source-built artifacts in the product / VMR build.Without this change, once repo PvP is enabled for
arcade, a ref pack ofSystem.IO.Packagingwould be bundled with one of the produced packages. It would then get loaded in duringsymreader's build, failing it in the process.Additionally, removed
Nuget.PackagingfromVersion.Detailsas an SBRP for the package can now be used - dotnet/source-build-reference-packages#673 (comment)