[WebToolsE2E] With no Docker or Podman installed, create Aspire Starter App with redis cache option and run, the error message calls out Docker not found but doesn't mention Podman

[balachir]

INSTALL STEPS

1. Clean machine: Win11 x64 23h2 ENU
2. Install Dev17.10.0 Preview 3.0 [main-34726.61] (Includes Aspire 8.0.0-preview.4.24156.9)
3. Install Aspire 8.0 P5 version 8.0.0-preview.5.24175.10 + Apply feeds
4. No Docker or Podman installed

REPRO STEPS

1. Create Aspire Starter App using command-line with redis cache option

   dotnet new aspire-starter -o AspireStarterApp03withRedis --use-redis-cache

2. Navigate to AppHost folder and run the app

   dotnet run

ACTUAL
You get the following error, which is expected. But the error is specific about Docker not being installed.

Question: Should the error be more general to indicate that either Docker or Podman needs to be installed.

Notes
With VS New Project dialog (NPD) too, the checkbox in NPD is specific about recommending Docker. See AzDO 2004980

[balachir]

@DamianEdwards @davidfowl for scenarios like these, are we fine with recommending Docker or should the messaging be more general and recommend either Docker or Podman?

cc: @karolz-ms

[DamianEdwards]

It should be generalized to something like "a supported container runtime"

[timheuer]

It should be generalized to something like "a supported container runtime"

David Pine just updated the doc point here about supported container runtime as well -- but I think the tool tip in VS doesn't allow hyperlink directly but we should put a readable aka.ms link (instead of FWLink)

[v-cazhang]

In AzDO bug 2004980, Vijay mentioned that:

This is in the templates:

aspire/src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/template.json

Lines 84 to 85 in ac2b068

	"displayName": "_Use Redis for caching (requires Docker)",
	"description": "Configures whether to setup the application to use Redis for caching. Requires Docker to run locally."

[DamianEdwards]

Yep I'm fixing this

[DamianEdwards]

Fixed

[phenning]

@DamianEdwards , you missed updating the templatestrings.en.json, so this still has the old value:

aspire/src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/localize/templatestrings.en.json

Line 7 in e0fe4a5

"symbols/UseRedisCache/displayName": "_Use Redis for caching (requires Docker)",

[DamianEdwards]

Grrrr, I apologize but will take this opportunity to vent and say this is one of the areas that is too finicky with template authoring. We need to either, a) automate these steps, or b) make the build fail if the required steps aren't performed, /Cc @joperezr

I don't think this is a ship-blocker for preview. 5 but we should get this fixed for preview.6

[joperezr]

cc @radical regarding the above point from @DamianEdwards about adding a build test to detect this moving forward. This doesn't take precedence over the existing testing work you are doing, but let's just keep it on the radar so we get to it eventually.

[radical]

cc @radical regarding the above point from @DamianEdwards about adding a build test to detect this moving forward. This doesn't take precedence over the existing testing work you are doing, but let's just keep it on the radar so we get to it eventually.

What would such a test do? Part of my current branch are tests that exercise some of the templates - IOW - dotnet new .. dotnet run. Is that the kind of thing expected or some other kind of template validation?

[DamianEdwards]

Ideally for this I think we'd have something as part of the templates project build, rather than a test. I guess it would verify that the keys in all the language templatestrings.*.json files match those in the template.json file, and that the values in the templatestrings.en.json file match those in the template.json file.

[phenning]

@baronfel @sayedihashimi is this something that could be baked into the template authoring validation tool?

(see @DamianEdwards issue in comment above.)

[baronfel]

Created a tracking issue on our end for the request.

[balachir]

@DamianEdwards FYI, I moved the status back to Ready for P6 so that we can track the additional change.

[balachir]

@DamianEdwards this seems to be fixed now with the latest Aspire P6 builds. Did you already make the additional change we discussed here and can we close this issue?

[DamianEdwards]

Yes I think it can be closed now.