Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview5] Update docker message in templates #3220

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 27, 2024

Backport of #3219 to release/8.0-preview5

Fixes #3190

/cc @DamianEdwards

Customer Impact

Testing

Risk

Microsoft Reviewers: Open in CodeFlow

@balachir
Copy link

@DamianEdwards this PR fixes the text shown for the 'Use redis' checkbox in New Project dialog, that's good. How about the error messages shown during Ctrl+F5? See the screenshot in ACTUAL part of #3190 - do those need to be fixed too?

@DamianEdwards DamianEdwards merged commit 0b1d21f into release/8.0-preview5 Mar 27, 2024
7 checks passed
@DamianEdwards DamianEdwards deleted the backport/pr-3219-to-release/8.0-preview5 branch March 27, 2024 17:47
@DamianEdwards
Copy link
Member

@balachir I didn't notice that part at all, sorry. Best to open separate issues in these cases. Let me follow up on that exception message.

@balachir
Copy link

@DamianEdwards thanks. Yeah sorry about the confusion with the multiple issues. I had actually opened #3190 for the docker exception message in Aspire.Hosting and a separate bug in AzDO 2004980 for the checkbox in NPD (assuming this needed a fix in VS). But things got mixed up a bit :).

@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants