Azure provisioning in the dashboard #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
davidfowl
force-pushed
the
davidfowl/azure-provisioner-dashboard
branch
from
7d8d69b
to
2a352e2
Compare
davidfowl
force-pushed
the
davidfowl/azure-provisioner-dashboard
branch
from
1f6a54f
to
8952fba
Compare
Show updates in UI from config Remove calls from resource Test changes Show connection strings WIP Tweaks to make it work - Return a snapshot on watch Remove lifecycle hook Fixed playground app Fix tests Remove connection strings until we get masking Cleanup Smaller diff Cleanup Small cleanup Send updates to dashboard when resources fail to start Post updates using NotificationService from the ApplicationExecutor
davidfowl
force-pushed
the
davidfowl/azure-provisioner-dashboard
branch
from
bd6818e
to
e691d7c
Compare
davidfowl
commented
Mar 2, 2024
| @@ -59,7 +60,9 @@ internal sealed class ApplicationExecutor(ILogger<ApplicationExecutor> logger, | |||
| IOptions<DcpOptions> options, | |||
| IDashboardEndpointProvider dashboardEndpointProvider, | |||
| IDashboardAvailability dashboardAvailability, | |||
| DistributedApplicationExecutionContext executionContext) | |||
| DistributedApplicationExecutionContext executionContext, | |||
There was a problem hiding this comment.
These changes look more complex than they are. The main changes are moving Create{Resource}Async out to a single method so that multiple resources can be started allocated in parallel. We also publish status updates for starting and failure (if it fails to start).
- Added logging when configuration is missing from azure provisioner
mitchdenny
reviewed
Mar 2, 2024
src/Aspire.Dashboard/Components/Controls/ResourceDetails.razor.cs
Outdated
Show resolved
Hide resolved
mitchdenny
approved these changes
Mar 2, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JamesNK
reviewed
Mar 2, 2024
- Ran the bicep playground as a stress test - Fixed bugs with not waiting properly - Fixed issues with shownig errors after failed provisions - Delete connection string commented out code
- Fixed sample
- Remove resouce id check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible (and cleaner IMO) to publish and log data about a resource to the dashboard and does that to show errors when creating resources and for showing provisioning progress when using the Aspire.Hosting.Azure.Provisioning package. This change consolidates the previously made annotations for publishing and subscribing to both resource updates and logs general purpose services instead of annotations.
TODO:
Fixes #2396
Fixes #2569
Contributes to #1758
Here's the bicep example:
Microsoft Reviewers: Open in CodeFlow