Use endpoint references for all allocated endpoint resolution #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This change removes setting manifest expressions strings in publish mode (except inputs) and pushes object references into the model directly. - This change also introduces IManifestExpressionProvider and IValueProvider as way for external code to represent manifest and values without code taking a strong dependendency on it. These are implemented on ParameterResource, IResourceWithConnectionString, EndpointReference and ConnectionStringReference in the core. - Introduce ConnectionStringReference which stores the underlying resource and an option bool (preserving the syntax of the call itself). - Added methods on EndpointReference to allow getting various parts of the URL - BicepOutputReference and BicepSecretOutputReference also implement the new interfaces.
- Use a default endpoint name for the redis endpoint
- Don't use lower level AllocatedEndpointAnnotation directly, instead use EndpointReference to represent the primary endpoint for container resources. - Pick a primary named endpoint
dotnet-issue-labeler
bot
added
the
area-app-model
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mitchdenny
approved these changes
Mar 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844
cc @eerhardt I assume this conflicts with your work so putting it up for review so you can see it (built on #2594)
cc @DamianEdwards this is how I assume we'd model parts of the url when trying to build the manifest.
Microsoft Reviewers: Open in CodeFlow