Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use endpoint references for all allocated endpoint resolution #2596

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Use endpoint references for all allocated endpoint resolution #2596

merged 8 commits into from
Mar 4, 2024

Commits on Mar 3, 2024

  1. Support live references in the application model 

    - This change removes setting manifest expressions strings in publish mode (except inputs) and pushes object references into the model directly.
- This change also introduces IManifestExpressionProvider and IValueProvider as way for external code to represent manifest and values without code taking a strong dependendency on it. These are implemented on ParameterResource, IResourceWithConnectionString, EndpointReference and ConnectionStringReference in the core.
- Introduce ConnectionStringReference which stores the underlying resource and an option bool (preserving the syntax of the call itself).
- Added methods on EndpointReference to allow getting various parts of the URL
- BicepOutputReference and BicepSecretOutputReference also implement the new interfaces.
    @davidfowl
    davidfowl committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    bbde56b View commit details
    Browse the repository at this point in the history

  2. Handle null and preserve rewrite behavior

    @davidfowl
    davidfowl committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    e3f4409 View commit details
    Browse the repository at this point in the history

  3. Fixed tests 

    - Use a default endpoint name for the redis endpoint
    @davidfowl
    davidfowl committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    d56eebe View commit details
    Browse the repository at this point in the history

  4. Back to tcp as the name

    @davidfowl
    davidfowl committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    32ae212 View commit details
    Browse the repository at this point in the history

  5. Use endpoint references for all allocated endpoint resolution 

    - Don't use lower level AllocatedEndpointAnnotation directly, instead use EndpointReference to represent the primary endpoint for container resources.
- Pick a primary named endpoint
    @davidfowl
    davidfowl committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    34566f6 View commit details
    Browse the repository at this point in the history

  6. Usings..

    @davidfowl
    davidfowl committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    34480c0 View commit details
    Browse the repository at this point in the history

  7. Fixed endpoint names

    @davidfowl
    davidfowl committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    8ef2373 View commit details
    Browse the repository at this point in the history

  8. Fixed moar tests

    @davidfowl
    davidfowl committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4a32275 View commit details
    Browse the repository at this point in the history