Make sure copy button is tab-accessible and visible on tab #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
approved these changes
Apr 1, 2024
| @@ -20,6 +20,6 @@ | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| ::deep:hover .defaultHidden { | |||
| ::deep:hover .defaultHidden, ::deep:focus-within .defaultHidden { | |||
There was a problem hiding this comment.
nit: I prefer to keep selectors on separate lines for easier scanning
There was a problem hiding this comment.
personally it confuses me more but I wouldn’t mind changing it
There was a problem hiding this comment.
😂 Personal preferences in coding styles are fun 😂
If I see one line I generally assume its just one (long) selector and then can vertically scan the selectors to see the differences with any that are grouped with it (e.g. the ::deep:hover would stand out from the ::deep:focus-within since they'd be aligned and right on top of each other).
I don't think we have any standards around this for the repo, so I'm fine either way. Just throwing it out there.
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Apr 3, 2024
Co-authored-by: Adam Ratzman <[email protected]>
adamint
added a commit
to adamint/aspire
that referenced
this pull request
Apr 8, 2024
Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit 2bba2ad)
RussKie
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Make sure copy button is tab-accessible and visible on tab (#3192) Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit 2bba2ad) * Avoid reconnection modal taking up entire screen, not being able to i… (#3189) * Avoid reconnection modal taking up entire screen, not being able to interact with page * add slight padding, shadow --------- Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit 87fab1e) * Force log level select position to be below (#3406) Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit 5a6856d) * Re-focus view button when closing details panel (#3368) * Re-focus button when closing details panel * Add internal id for log entries, make sure to null element id on detail view closed * Make sure view button is selected only after a user action --------- Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit e784c91)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can add a tabindex to GridValue buttons to make sure they are keyboard navigable in data grids, and we can use the focus-within event to set opacity on keyboard focus
Fixes #3175
Microsoft Reviewers: Open in CodeFlow