[release/8.0]: Backport accessibility fixes into 8.0 #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit 2bba2ad)
dotnet#3189) * Avoid reconnection modal taking up entire screen, not being able to interact with page * add slight padding, shadow --------- Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit 87fab1e)
Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit 5a6856d)
* Re-focus button when closing details panel * Add internal id for log entries, make sure to null element id on detail view closed * Make sure view button is selected only after a user action --------- Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit e784c91)
dotnet-policy-service
bot
added
the
Servicing-consider
kvenkatrajan
approved these changes
Apr 8, 2024
danmoseley
added
Servicing-approved
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #3192, #3406, #3368, and #3189
Customer Impact
#3192 makes copy buttons inside data grids accessible to keyboard-only users. The workaround for them without this pull request is to manually select the entire cell's contents.
#3406 makes the log level select on StructuredLogs pages accessible to users with high resolution + high zoom. The element is inaccessible to them without that change.
#3368 Prevents focus state from being lost when closing a details panel manually. Otherwise, keyboard/screen-reader users will be confused when focus is removed from the page after closing the panel.
#3189 Modifies the reconnection UI to allow users to interact with on-screen elements.
Testing
Manual verification. See demo below (first #3192, then #3368, then #3189 at the end):
Risk
Low
Microsoft Reviewers: Open in CodeFlow