Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Service Discovery README to reflect API changes #3228

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Mar 27, 2024

  • Rename UseServiceDiscovery to AddServiceDiscovery
  • Adapt to new config schema
  • Document scheme selection
  • Remove endpoint selectors
Microsoft Reviewers: Open in CodeFlow

@IEvangelist
Copy link
Member

We might need to update this again in the near future. We should correct the spelling of EndPoint throughout Aspire to be Endpoint.

-EndPoint
+Endpoint

See #782 (comment)

@ReubenBond
Copy link
Member Author

@IEvangelist done via #3413

@ReubenBond ReubenBond force-pushed the rebond/sd-readme-use-to-add branch 2 times, most recently from 8288924 to cae1e95 Compare April 5, 2024 23:19
@ReubenBond ReubenBond enabled auto-merge (squash) April 8, 2024 21:20
@ReubenBond ReubenBond merged commit af16e09 into main Apr 8, 2024
8 checks passed
@ReubenBond ReubenBond deleted the rebond/sd-readme-use-to-add branch April 8, 2024 22:06
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants