Service Discovery: Implement approved API #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Across **/PublicAPI.Shipped.txt, I see 261 instances of "Point" and 871 instances of "point" (text matches, not symbol names). Edit: It was pointed out to me that this PR is in dotnet/aspire and not dotnet/aspnetcore. 🤦 |
amcasey
reviewed
Apr 5, 2024
...crosoft.Extensions.ServiceDiscovery/PassThrough/PassThroughServiceEndpointProviderFactory.cs
Outdated
Show resolved
Hide resolved
amcasey
reviewed
Apr 5, 2024
src/Microsoft.Extensions.ServiceDiscovery.Abstractions/Internal/ServiceEndpointImpl.cs
Outdated
Show resolved
Hide resolved
amcasey
reviewed
Apr 5, 2024
src/Microsoft.Extensions.ServiceDiscovery.Abstractions/ServiceEndpoint.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Apr 5, 2024
src/Microsoft.Extensions.ServiceDiscovery.Abstractions/ServiceEndpoint.cs
Outdated
Show resolved
Hide resolved
…Endpoint.cs Co-authored-by: Stephen Halter <[email protected]>
amcasey
approved these changes
Apr 5, 2024
ReubenBond
force-pushed
the
rebond/sd-final-api
branch
from
1c3f56d
to
fc1c786
Compare
This was referenced Apr 5, 2024
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8584565472 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes decided on during the final API review: dotnet/aspnetcore#53715 (comment)
Fixes dotnet/aspnetcore#53715
Microsoft Reviewers: Open in CodeFlow