-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithManagementPlugin() method for RabbitMQ management plugin #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-codeflow
for labeling automated codeflow. intentionally a different color!
label
Mar 27, 2024
eerhardt
approved these changes
Mar 27, 2024
attilah
reviewed
Mar 27, 2024
timheuer
reviewed
Mar 27, 2024
Co-authored-by: Eric Erhardt <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
DamianEdwards
changed the title
Enable RabbitMQ management plugin in run mode
Add WithManagementPlugin() method for RabbitMQ management plugin
Mar 28, 2024
/backport to release/8.0-preview5 |
Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8463454385 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
WithManagementPlugin()
extension method for the RabbitMQ resource to update the container image with the management plugin enabled and expose its HTTP endpoint. The method checks that the image name and tag are known and supported before updating the tag to enable the management plugin, otherwise it throws.It also updates the doc comments to better match the format used for the Redis resource.
Fixes #2067
Microsoft Reviewers: Open in CodeFlow