Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview5] Add WithManagementPlugin() method for RabbitMQ management plugin #3247

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 28, 2024

Backport of #3230 to release/8.0-preview5

/cc @davidfowl @DamianEdwards

Customer Impact

Support for RabbitMQ management plugin was originally included in the early previews of Aspire before being removed during an API change around with the intention to bring it back. Since then, a new pattern was established for Aspire container resources that have optional admin tools (e.g. pgAdmin, Redis Commander) of having an extension method to enable the admin tool. Without this change, users will not be able to easily enable the RabbitMQ management plugin on RabbitMQ resources as they could in early previews, and as can be done for other resource types.

Testing

Unit tests added and the TestShop playground app updated to use the new method and verified manually

Risk

Low

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 28, 2024
@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DamianEdwards DamianEdwards enabled auto-merge (squash) March 28, 2024 14:30
@DamianEdwards DamianEdwards merged commit 8d613b3 into release/8.0-preview5 Mar 28, 2024
7 checks passed
@DamianEdwards DamianEdwards deleted the backport/pr-3230-to-release/8.0-preview5 branch March 28, 2024 14:50
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants