[release/8.0] Service Discovery: Implement approved API #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…Endpoint.cs Co-authored-by: Stephen Halter <[email protected]>
ReubenBond
requested review from
davidfowl,
amcasey,
BrennanConroy and
adityamandaleeka
BrennanConroy
approved these changes
Apr 9, 2024
amcasey
approved these changes
Apr 9, 2024
danmoseley
added
Servicing-approved
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3413 to release/8.0
/cc @ReubenBond
Customer Impact
This implements the approved API for Service Discovery
Testing
Automated & manual.
Risk
Low: the majority of the API surface is unchanged. There was one user-facing API which changed, so preview projects will need to change
UseServiceDiscoverytoAddServiceDiscoveryin one section. We have tooling to help. The rest of the changes are internal.Regression?
No.
Microsoft Reviewers: Open in CodeFlow