Add IResourceWithServiceDiscovery interface to PythonProjectResource. #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
|
/backport to release/8.1 |
|
Started backporting to release/8.1: https://github.com/dotnet/aspire/actions/runs/10053595404 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
IEvangelist
approved these changes
Jul 23, 2024
mitchdenny
deleted the
mitchdenny/add-service-discovery-interface-to-python
branch
|
Are there any tests we could write to ensure this works end-to-end? |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5019
We were just missing the marker interface. This will result in the service discovery variables be populated with
WithRefrence(...)is used. It also unlocksWithEnvironment(string, EndpointReference)which is arguably more useful in these polyglot scenarios.Microsoft Reviewers: Open in CodeFlow