[release/8.1] Add IResourceWithServiceDiscovery interface to PythonProjectResource. #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-app-model
joperezr
approved these changes
Jul 23, 2024
|
Critical scenario that we expect many users to hit: Approved. |
mitchdenny
approved these changes
Jul 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5024 to release/8.1
/cc @mitchdenny
Customer Impact
Without this change we can't WithReference to or from a python project. This was only just discovered. Its a minor change to enable the built-in service discovery behavior.
Testing
Manual. We have automated testing for WithReference generally but not the python resource specifically. However this functionality isn't specific to the python resource (other than the presence of the marker interface). Note that python resource just builds on top of executableresource which already works.
Risk
Low.
Regression?
Microsoft Reviewers: Open in CodeFlow