Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0-preview1]: Last round of triple slash, I believe. (#661) #663

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[release/8.0-preview1]: Last round of triple slash, I believe. (#661) #663

merged 1 commit into from
Nov 2, 2023

Conversation

davidfowl
Copy link
Member

Backport #661

@IEvangelist @davidfowl
Last round of triple slash, I believe. (#661)
3711fa5 
* Last round of triple slash, I believe.

* Revert Aspire.sln change

* Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs

* Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs

---------

Co-authored-by: David Fowler <[email protected]>
eerhardt
eerhardt approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt eerhardt enabled auto-merge (squash) November 2, 2023 17:19
@eerhardt eerhardt merged commit e209f83 into release/8.0-preview1 Nov 2, 2023
6 checks passed
@eerhardt eerhardt deleted the davidfowl/xmldocs branch November 2, 2023 17:31
joperezr added a commit that referenced this pull request Nov 14, 2023
@joperezr
Merged PR 35034: Merge branch 'release/8.0-preview1' into 'internal/r…
f58a51b 
…elease/8.0-preview1'

Related work items: #592, #602, #607, #617, #622, #624, #626, #627, #632, #638, #639, #640, #644, #647, #649, #650, #651, #652, #653, #656, #663
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexwolfmsft alexwolfmsft alexwolfmsft approved these changes

@eerhardt eerhardt eerhardt approved these changes

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidfowl @IEvangelist @eerhardt @alexwolfmsft