Switch to using MicrosoftNETCorePlatformsPackageVersion #19130
Conversation
…eFrameworkVersion parameter in the test wrappers and SDK props file
|
After merging #19044 I realized that I was using the wrong version to restore against. If it happens to line up (as it did before the merge), it works fine, but can break if the netcoreapp version doesn't match the runtime version. |
|
@dotnet-bot test OSX10.12 x64 Checked CoreFX Tests please |
|
Actually I have hit the problem, however, it seems to be part of larger test dependency graph inconsistencies which result in a bunch of warnings. I am working on fixing in #19109 PR. However, this change does not affect my work. |
|
@dotnet-bot test OSX10.12 x64 Checked CoreFX Tests please |
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp3.0</TargetFramework> | |||
| <RuntimeFrameworkVersion>$(MicrosoftNETCoreRuntimeCoreCLRPackageVersion)</RuntimeFrameworkVersion> | |||
| <RuntimeFrameworkVersion>$(MicrosoftNETCorePlatformsPackageVersion)</RuntimeFrameworkVersion> | |||
There was a problem hiding this comment.
You should know that this doesn't map to the version of Microsoft.NETCore.App if that is what you are trying to get here. It does it a lot of cases but not in all cases.
There was a problem hiding this comment.
Oh, interesting. Is there a better value to use?
There was a problem hiding this comment.
It doesn't look like you guys consume Microsoft.NETCore.App directly in coreclr. If it is a true dependency then you guys should start consuming it like corefx does https://github.com/dotnet/corefx/blob/master/dependencies.props#L42.
…eFrameworkVersion parameter in the test wrappers and SDK props file (dotnet#19130)
Switch to using MicrosoftNETCorePlatformsPackageVersion as the RuntimeFrameworkVersion parameter in the test wrappers and SDK props file.
Ensures there is always the correct version of netcoreapp selected during restore + build, and prevents the tests from failing to build because they were restored against a different version.