This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add netcoreapp dependencies #19177
Merged
Add netcoreapp dependencies #19177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MicrosoftNETCoreAppPackageVersion property - Add required coresetup dependency build infos
|
This is a follow up of #19130 As mentioned by @weshaggard there, MicrosoftNETCorePlatformsPackageVersion isn't always the same as MicrosoftNETCoreAppPackageVersion, which is what we actually want to use |
chsienki
requested review from
weshaggard,
RussKeldorph and
AaronRobinsonMSFT
and removed request for
RussKeldorph
AaronRobinsonMSFT
approved these changes
Jul 30, 2018
|
@dotnet-bot test OSX10.12 x64 Checked CoreFX Tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MicrosoftNETCoreAppPackageVersion to the dependencies.props file and the required RemoteDependencyBuildInfo so that maestro will keep it updated.
Use this property in the test projects to ensure they have the correct RuntimeFrameworkVersion property.