Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SatelliteResourceLanguages property #26171

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Add SatelliteResourceLanguages property #26171

merged 3 commits into from
Sep 17, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 16, 2021 •
edited
Loading

@dotnet-bot dotnet-bot added this to the September 2021 milestone Sep 16, 2021
@gewarren gewarren requested review from DamianEdwards and a team September 16, 2021 22:52
DamianEdwards
DamianEdwards approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The property applies equally to build and publish output so might be worth making that clear.

docs/core/project-sdk/msbuild-props.md Outdated Show resolved Hide resolved
BillWagner
BillWagner approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gewarren

This LGTM, once you accept Damien's suggestion.

@gewarren
Copy link
Contributor Author

Thanks Damian and Bill!

@gewarren gewarren merged commit ad10d3d into dotnet:main Sep 17, 2021
@gewarren gewarren deleted the satellite branch September 17, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianEdwards DamianEdwards DamianEdwards approved these changes

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
September 2021
Development

Successfully merging this pull request may close these issues.

Document the SatelliteResourceLanguages MSBuild property
4 participants
@gewarren @DamianEdwards @BillWagner @dotnet-bot