Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UninitializedDbSetDiagnosticSuppressor doesn't work when a constructor is present #26879

Closed
roji opened this issue Dec 2, 2021 · 1 comment · Fixed by #27869
Closed

UninitializedDbSetDiagnosticSuppressor doesn't work when a constructor is present #26879

roji opened this issue Dec 2, 2021 · 1 comment · Fixed by #27869
Assignees
@roji
Labels
area-analyzer area-dbcontext closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
7.0.0

Comments

@roji
Copy link
Member

roji commented Dec 2, 2021 •
edited
Loading

#21608 introduced a DiagnosticsSuppressor to suppress CS8618 (non-nullable property is uninitialized) for DbSet properties on DbContexts. This currently works fine as long as there is no constructor on the DbContext, but fails if a constructor is defined, since the diagnostic is reported on the constructor declaration, and not on the property.

Roslyn issue: dotnet/roslyn#58073
@roji roji self-assigned this Dec 2, 2021
@roji roji mentioned this issue Dec 2, 2021
Closed
@roji roji added the blocked label Dec 2, 2021
@ajcvickers ajcvickers added this to the 7.0.0 milestone Dec 9, 2021
@roji
Copy link
Member Author

roji commented Jan 29, 2022

Roslyn-side issue has been fixed - this should be unblocked in preview3.

@roji roji added area-dbcontext closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed blocked labels Apr 22, 2022
roji added a commit to roji/efcore that referenced this issue Apr 22, 2022
@roji
Suppress uninitialized DbSet warnings when a ctor is present
4f326a5 
Fixes dotnet#26879
@roji roji mentioned this issue Apr 22, 2022
Merged
roji added a commit to roji/efcore that referenced this issue Apr 22, 2022
@roji
Suppress uninitialized DbSet warnings when a ctor is present
4890196 
Fixes dotnet#26879
roji added a commit that referenced this issue Apr 26, 2022
@roji
Suppress uninitialized DbSet warnings when a ctor is present (#27869)
2858513 
Fixes #26879
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview5 May 4, 2022
@roji roji mentioned this issue Aug 14, 2022
Merged
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview5, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-analyzer area-dbcontext closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Suppress uninitialized DbSet warnings when a ctor is present roji/efcore
2 participants
@ajcvickers @roji