Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress uninitialized DbSet warnings when a ctor is present #27869

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Suppress uninitialized DbSet warnings when a ctor is present #27869

merged 1 commit into from
Apr 26, 2022

Conversation

roji
Copy link
Member

@roji roji commented Apr 22, 2022

Fixes #26879

@roji roji requested a review from dougbu as a code owner April 22, 2022 22:29
@roji roji mentioned this pull request Apr 22, 2022
Closed
dougbu
dougbu reviewed Apr 22, 2022
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection to the Microsoft.CodeAnalysis bump but suggest someone else review the code 😸

@roji roji force-pushed the UninitializedDbSetSuppressor branch from 4f326a5 to 4890196 Compare April 22, 2022 23:16
@roji roji requested a review from a team April 22, 2022 23:20
@roji roji merged commit 2858513 into dotnet:main Apr 26, 2022
@roji roji deleted the UninitializedDbSetSuppressor branch April 26, 2022 08:11
@roji roji mentioned this pull request Apr 27, 2022
Closed
@ajcvickers ajcvickers mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu left review comments

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UninitializedDbSetDiagnosticSuppressor doesn't work when a constructor is present
3 participants
@roji @dougbu @AndriySvyryd