Query: Add identifier appropriately when generating joins #20599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We skipped doing it during left join which was incorrect. We need to apply it for every join and account for it could be null for LeftJoin/OuterApply. - Make columnExpression.Type nullble if it is nullable. - Add some fancy code in TestSqlLoggerFactory to write directly into file updating baselines (I ran into updating 234 baselines). - Off by default - Can set indent if it is higher than usual - Only works when number of lines do not change
|
Ping @maumar |
maumar
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We skipped doing it during left join which was incorrect.
We need to apply it for every join and account for it could be null for LeftJoin/OuterApply.