Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Add identifier appropriately when generating joins #20599

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Query: Add identifier appropriately when generating joins #20599

merged 1 commit into from
Apr 17, 2020

Commits on Apr 11, 2020

  1. Query: Add identifier appropriately when generating joins 

    We skipped doing it during left join which was incorrect.
We need to apply it for every join and account for it could be null for LeftJoin/OuterApply.

- Make columnExpression.Type nullble if it is nullable.
- Add some fancy code in TestSqlLoggerFactory to write directly into file updating baselines (I ran into updating 234 baselines).
  - Off by default
  - Can set indent if it is higher than usual
  - Only works when number of lines do not change
    @smitpatel
    smitpatel committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    2f3701a View commit details
    Browse the repository at this point in the history