Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common console utility classes #173

Closed
natemcmaster opened this issue Nov 30, 2016 · 0 comments
Closed

Add common console utility classes #173

natemcmaster opened this issue Nov 30, 2016 · 0 comments
Assignees
@natemcmaster
Milestone
2.0.0-preview1

Comments

@natemcmaster
Copy link

natemcmaster commented Nov 30, 2016 •
edited
Loading

We should consider reducing duplicate APIs into a common abstraction.

Examples:
Microsoft.Extensions.Tools.Internal.IConsole (aspnet/dotnettools)
MIcrosoft.Extensions.Logging.Console.Internal.IConsole (aspnet/logging)

Microsoft.DotNet.Cli.Utils.ArgumentEscaper (dotnet/cli)
Microsoft.Extensions.Tools.Internal.ArgumentEscaper (aspnet/dotnettools)
Microsoft.EntityFrameworkCore.Tools.VisualStudio.Internal.ArgumentEscaper (aspnet/entityframework.tools)

Microsoft.DotNet.Cli.Utils.Muxer (from dotnet/cli)
Microsoft.Extensions.Tools.Internal.DotNetMuxer (aspnet/dotnettools)
Internal.AspNetCore.BuildTools.Tasks.GetDotNetHost (aspnet/buildtools)

Some of this duplication was introduced to break a cyclical dependency between aspnet and CLI. https://github.com/dotnet/cli/issues/4745#issuecomment-261396513

cc @piotrpMSFT @BrennanConroy
@natemcmaster natemcmaster mentioned this issue Nov 30, 2016
Merged
@natemcmaster natemcmaster mentioned this issue Mar 7, 2017
Closed
@natemcmaster natemcmaster mentioned this issue Mar 14, 2017
Merged
@natemcmaster natemcmaster self-assigned this Mar 22, 2017
@natemcmaster natemcmaster added this to the 2.0.0-preview1 milestone Mar 22, 2017
@natemcmaster natemcmaster changed the title Add more abstractions for console tools Add common console utility classes Mar 22, 2017
natemcmaster pushed a commit that referenced this issue Nov 6, 2018
@davidfowl
Merge pull request #173 from aspnet/no-mono
f353953 
No mono
natemcmaster pushed a commit that referenced this issue Nov 16, 2018
@rynowak
Merge pull request #173 from dotnet-maestro-bot/merge/release/2.2-to-…
4ed1a66 
…master

[automated] Merge branch 'release/2.2' => 'master'
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@natemcmaster natemcmaster

Labels
None yet
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
1 participant
@natemcmaster