-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move common command line code into CommandLineUtils #201
Conversation
cce3eee
to
d1e3a32
Compare
Can we chat for a few minutes about the various command line changes being proposed (not just this change)? |
⌚ until triage discussion next week. |
770777c
to
d588798
Compare
🆙 📅 rebased on #205. Now that CommandLineUtils is a .Sources package only, we shouldn't have to worry as much about API review on this. This is just putting code in a common location that we already have duplicated in a few places. |
See also aspnet/DotNetTools#280 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change overall looks good. I'm just wondering why some of the files moved into a CommandLineApplication
subfolder despite that not being in the namespace?
I don't remember what I was thinking. Updated with that change reverted. |
Re-approved 😄 |
e182bd5
to
a11ef27
Compare
These APIs are commonly used in other ASP.NET Core tools. This change puts the API into this shared library for use across all repos.
a11ef27
to
077dceb
Compare
Remove duplication from our code.
We have duplicate implementations of this code scattered around a few projects. By putting htis here, we can remove the duplicate code from aspnet/DotNetTools, aspnet/EntityFramework.Tools, aspnet/BuildTools, and maybe more.
Resolves #173
cc @Eilon @muratg should we API review these before we add this?