Move common command line code into CommandLineUtils #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
force-pushed
the
namc/cli-api
branch
from
cce3eee
to
d1e3a32
Compare
|
Can we chat for a few minutes about the various command line changes being proposed (not just this change)? |
|
⌚ until triage discussion next week. |
natemcmaster
force-pushed
the
namc/cli-api
branch
2 times, most recently
from
770777c
to
d588798
Compare
|
🆙 📅 rebased on #205. Now that CommandLineUtils is a .Sources package only, we shouldn't have to worry as much about API review on this. This is just putting code in a common location that we already have duplicated in a few places. |
|
See also aspnet/DotNetTools#280 |
Eilon
approved these changes
Mar 22, 2017
I don't remember what I was thinking. Updated with that change reverted. |
Eilon
approved these changes
Mar 22, 2017
|
Re-approved 😄 |
natemcmaster
force-pushed
the
namc/cli-api
branch
2 times, most recently
from
e182bd5
to
a11ef27
Compare
These APIs are commonly used in other ASP.NET Core tools. This change puts the API into this shared library for use across all repos.
natemcmaster
force-pushed
the
namc/cli-api
branch
from
a11ef27
to
077dceb
Compare
natemcmaster
pushed a commit
that referenced
this pull request
Nov 5, 2018
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplication from our code.
We have duplicate implementations of this code scattered around a few projects. By putting htis here, we can remove the duplicate code from aspnet/DotNetTools, aspnet/EntityFramework.Tools, aspnet/BuildTools, and maybe more.
Resolves #173
cc @Eilon @muratg should we API review these before we add this?