Fix [NoDataClassification] attribute handling in logging source-gen #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging code generator wasn't aware of the NoDataClassification attribute and treated the associated data as having in fact a data classification. This led to an incorrect warning. In addition, what should have been a warning was treated like an error and aborted compilation. Now, if the legit problem occurs, it will be reported as warning and not stop compilation.
xakep139
approved these changes
Jun 3, 2024
xakep139
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5188
The logging code generator wasn't aware of the
NoDataClassificationattribute and treated theassociated data as having in fact a data classification. This led to an incorrect warning.
In addition, what should have been a warning was
treated like an error and aborted compilation. Now, if the legit problem occurs, it will be reported
as warning and not stop compilation.
Microsoft Reviewers: Open in CodeFlow