Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [NoDataClassification] attribute handling in logging source-gen #5191

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Fix [NoDataClassification] attribute handling in logging source-gen #5191

merged 1 commit into from
Jun 3, 2024

Commits on May 31, 2024

  1. Fix #5188 

    The logging code generator wasn't aware of the
NoDataClassification attribute and treated the
associated data as having in fact a data classification.
This led to an incorrect warning.

In addition, what should have been a warning was
treated like an error and aborted compilation. Now,
if the legit problem occurs, it will be reported
as warning and not stop compilation.
    Martin Taillefer committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d3b0c7d View commit details
    Browse the repository at this point in the history