Use background CancellableTask in VS instead of async & asyncMaybe #15187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I installed it and, at first glance, nothing bad happened. Colorization kick in, errors in editor show up and clear up quickly. |
|
Updated a bunch more services, the latest vsix is in original post, I will be updating it from time to time, if someone wants to test (should work in 17.6 and 17.7, not 17.5 though). |
|
I think this is ready as a first batch, to not leave it in PR state forever, we better get it in 17.7 early and start playing with it. I have moved major functionality to tasks, but not go to defition, I prefer to have it as a separate issue, since a bunch of rewriting will be involved. Update: I have updated VSIX in the OP, please do install and test it |
vzarytovskii
commented
May 11, 2023
|
Ok, I'd probably want to merge it after we have telemetry in 17.7, to see what's the difference |
0101
approved these changes
May 11, 2023
xperiandri
suggested changes
May 18, 2023
Co-authored-by: Andrii Chebukin <[email protected]>
This reverts commit bf51b31.
KevinRansom
approved these changes
May 19, 2023
T-Gro
approved these changes
May 22, 2023
Co-authored-by: vzarytovskii <[email protected]>
…sharp into cancellable-tasks
Co-authored-by: vzarytovskii <[email protected]>
|
When CI is green, I am going to merge this one, unless anyone has any additional comments. |
psfinaki
reviewed
May 25, 2023
psfinaki
reviewed
May 25, 2023
psfinaki
reviewed
May 25, 2023
Co-authored-by: Petr <[email protected]>
vzarytovskii
added a commit
that referenced
this pull request
May 31, 2023
* LexFilter: cleanup whitespaces (#15250) * Parser: rewrite tuple expr recovery to allow better items recovery (#15227) * Checker: recover on unknown record fields (#15214) * Make anycpu work correctly on Arm64 (#15234) * Makeanuycpu work correctly on arm64 * Update Microsoft.FSharp.Targets * Fix15254 (#15257) * Deploy only compressed metadata for dotnet sdk implementation (#15230) * compress fsharp for sdk * Update FSharp.DependencyManager.Nuget.fsproj * Parser: more binary expressions recovery (#15255) * Use background CancellableTask in VS instead of async & asyncMaybe (#15187) * wip * iteration * iteration: quickinfo, help context * fantomas * todo * moved tasks to editor project, fixed comment colouring bug * fantomas * Fantomas + PR feedback * Update vsintegration/src/FSharp.Editor/Hints/HintService.fs Co-authored-by: Andrii Chebukin <[email protected]> * Revert "Update vsintegration/src/FSharp.Editor/Hints/HintService.fs" This reverts commit bf51b31. --------- Co-authored-by: Andrii Chebukin <[email protected]> * Name resolution: actually add reported item when trying to replace (#14772) Co-authored-by: Tomas Grosup <[email protected]> * Move flatErrors tests from fsharpqa (#15251) * temp * tests * flaterrors * update tests * preserve ranges in result of UnsolvedTyparsOfModuleDef to help with warnings (#15243) * preserve ranges in result of UnsolvedTyparsOfModuleDef to help with warnings * use fallback range only for range0 * pattern match instead of Option.isSome * Add test * Revert "Add test" This reverts commit e05e808. * Make `FSharpReferencedProject` representation public (#15266) * Make FSharpReferencedProject representation public * Update surface area * Fantomas * Fantomas --------- Co-authored-by: Tomas Grosup <[email protected]> * Fix navigation for external enums, DUs and name resultion for members (#15270) * Update FSharp.Compiler.Service.SurfaceArea.netstandard20.debug.bsl * Add warning when compiler selects among multiple record type candidates, fslang-suggestion 1091 (#15256) * Protect assembly exploration for C# extension members (#15271) * Compute ValInline.Never for externs (#15274) * Compute ValInline.Never for externs --------- Co-authored-by: Eugene Auduchinok <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: Andrii Chebukin <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: dawe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems previous PR shomehow got closed for some reason?
More of an experiment by now, will be migrating things one-by-one and see what are the implications.
So far, it feels snappy.
@0101 @majocha @TheAngryByrd if you have any feedback, that'll be great. Also, if you'd like to test it, just build vsix and try in your VS installation.
VSIX(updated on every change): https://1drv.ms/u/s!AiT31MwroM_3lfUYVfV8H3l14MZfpg?e=JDGyhR (should work in 17.6 and higher)