Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make anycpu work correctly on Arm64 #15234

Merged
merged 6 commits into from
May 23, 2023
Merged

Conversation

KevinRansom
Copy link
Member

We provide an FSharpPreferAnyCpuTools property in msbuild the purpose is to allow a developer to specify that when using the preferring desktop compilers it should use the anycpu version of the FSharp compiler.

This property supercedes the FSharpPrefer64BitTools msbuild property that provided similar functionality before VisualStudio became 64bit only.

On an Arm64 PC this flag has particular importance because Windows runs AnyCPU under an emulator, so this may be required for compatibility builds.

@KevinRansom KevinRansom requested a review from a team as a code owner May 18, 2023 03:02
@KevinRansom KevinRansom merged commit bacdc8a into dotnet:main May 23, 2023
@KevinRansom KevinRansom added this to the May-2023 milestone May 24, 2023
@KevinRansom KevinRansom self-assigned this May 24, 2023
vzarytovskii added a commit that referenced this pull request May 31, 2023
* LexFilter: cleanup whitespaces (#15250)

* Parser: rewrite tuple expr recovery to allow better items recovery (#15227)

* Checker: recover on unknown record fields (#15214)

* Make anycpu work correctly on Arm64 (#15234)

* Makeanuycpu work correctly on arm64

* Update Microsoft.FSharp.Targets

* Fix15254 (#15257)

* Deploy only compressed metadata for dotnet sdk implementation (#15230)

* compress fsharp for sdk

* Update FSharp.DependencyManager.Nuget.fsproj

* Parser: more binary expressions recovery (#15255)

* Use background CancellableTask in VS instead of async & asyncMaybe (#15187)

* wip

* iteration

* iteration: quickinfo, help context

* fantomas

* todo

* moved tasks to editor project, fixed comment colouring bug

* fantomas

* Fantomas + PR feedback

* Update vsintegration/src/FSharp.Editor/Hints/HintService.fs

Co-authored-by: Andrii Chebukin <[email protected]>

* Revert "Update vsintegration/src/FSharp.Editor/Hints/HintService.fs"

This reverts commit bf51b31.

---------

Co-authored-by: Andrii Chebukin <[email protected]>

* Name resolution: actually add reported item when trying to replace (#14772)

Co-authored-by: Tomas Grosup <[email protected]>

* Move flatErrors tests from fsharpqa (#15251)

* temp

* tests

* flaterrors

* update tests

* preserve ranges in result of UnsolvedTyparsOfModuleDef to help with warnings (#15243)

* preserve ranges in result of UnsolvedTyparsOfModuleDef to help with warnings

* use fallback range only for range0

* pattern match instead of Option.isSome

* Add test

* Revert "Add test"

This reverts commit e05e808.

* Make `FSharpReferencedProject` representation public (#15266)

* Make FSharpReferencedProject representation public

* Update surface area

* Fantomas

* Fantomas

---------

Co-authored-by: Tomas Grosup <[email protected]>

* Fix navigation for external enums, DUs and name resultion for members (#15270)

* Update FSharp.Compiler.Service.SurfaceArea.netstandard20.debug.bsl

* Add warning when compiler selects among multiple record type candidates, fslang-suggestion 1091 (#15256)

* Protect assembly exploration for C# extension members (#15271)

* Compute ValInline.Never for externs (#15274)

* Compute ValInline.Never for externs

---------

Co-authored-by: Eugene Auduchinok <[email protected]>
Co-authored-by: Kevin Ransom (msft) <[email protected]>
Co-authored-by: Vlad Zarytovskii <[email protected]>
Co-authored-by: Andrii Chebukin <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: dawe <[email protected]>
@KevinRansom KevinRansom deleted the preferanycpu branch March 21, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants