Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netstandard2 #6814

Merged
merged 4 commits into from
May 25, 2019
Merged

Netstandard2 #6814

merged 4 commits into from
May 25, 2019

Conversation

KevinRansom
Copy link
Member

Original PR: #6771

FSharp.Core is updated to target netstandard2.0 as the minimum required platform.
The FSharp.Core nuget package version 4.7.0, will contain net45 and netstandard2.0 dlls
with the version number 4.7.0.0

This PR enables the FSharpFunc API's that use the System.Converter class.
Apparently the API Surface area tests have not been running, so I have re-enabled them, added back in the APIs that were missing. Some have moved around the baseline.
master will not be updated to a netstandard2.0 until after VS2019.2 has RTM'd

@KevinRansom KevinRansom reopened this May 22, 2019
FSharp.Profiles.props Outdated Show resolved Hide resolved
@KevinRansom KevinRansom merged commit 9d5ad12 into dotnet:release/fsharp47 May 25, 2019
@dsyme
Copy link
Contributor

dsyme commented Jun 7, 2019

This makes me so happy :)

@dsyme
Copy link
Contributor

dsyme commented Jun 15, 2019

I'm struggling to understand why this went into release\fsharp47 instead of master or release\dev16.2 or ....

@cartermp
Copy link
Contributor

@dsyme Because netstandard1.6 is for code sharing with the .NET Core 1.x release set, and .NET Core 1.x is still in LTS until this end of June 27th, we decided to keep theofficially supported release with this as the target until it is deprecated.

Since we need code flow from master -> release/dev16.2 and into release/dev16.2 and don't want to pull in this as a takeback while it's still in LTS, we're holding this off in release/fsharp47, which will merge into the release/dev16.3 release (which is also the .NET Core 3.0 release).

@cartermp cartermp added this to the .NET Core 3.0 milestone Jun 17, 2019
@KevinRansom KevinRansom deleted the netstandard2 branch July 2, 2019 22:36
@cartermp cartermp modified the milestones: .NET Core 3.0, 16.3 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants