Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netstandard2.0 target to FSharp.Core project and nuget package #6956

Closed

Conversation

jack-pappas
Copy link
Contributor

@jack-pappas jack-pappas commented Jun 7, 2019

I noticed recently the FSharp.Core package on Nuget claims to support net45, netstandard1.6, and netstandard2.0. However, after downloading and inspecting the package, I found it only has net45 and netstandard1.6 binaries but no netstandard2.0 binaries.

This isn't a huge deal -- you can use the netstandard1.6 version of FSharp.Core when e.g. building a library targeting netstandard2.0. It is a bit annoying though, because referencing the netstandard1.6 version of FSharp.Core causes some additional packages (which aren't needed for netstandard2.0) to be pulled into a build and referenced by any netstandard2.0 libraries built with F#.

I've simply added the additional netstandard2.0 target framework to the FSharp.Core project + .nuspec files here, which means we'll actually have a netstandard2.0 version of FSharp.Core in the Nuget package, as advertised.

This change can stand on it's own*, but at present will still be using some conditional-compilation workarounds needed for netstandard1.6. I've submitted a separate, also-standalone PR in #6955 to address that.

@matthid
Copy link
Contributor

matthid commented Jun 7, 2019

please see #3454 (comment)
In the past reasoning was that there are hard restrictions on package size of FSharp.Core to get bundled with dotnet sdk... This is the reason it looks this way - which apparently is a supported scenario (at least no issue was reported for years)

@cartermp
Copy link
Contributor

cartermp commented Jun 7, 2019

@jack-pappas see here: #6814

We will be .NET Standard 2.0 for the F# 4.7 release later this year.

Because .NET Core 1.x support ends on June 27th, we still need to support a netstandard1.6 component as it was designed to work with that .NET Core version.

@KevinRansom
Copy link
Member

@jack-pappas

this is already taken care of the branch fsharp47, that will make it's way back into master later in the year. Until then master needs to produce fsharp.core for netstandard1.6

Kevin

@KevinRansom KevinRansom closed this Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants