Support for short stack builds. #18463
Conversation
Tested with android-x64 and android-amd64 on Linux x64, and iossimulator-x64 on macOS ARM64. Depends on dotnet/runtime#97725
| @@ -6,6 +6,18 @@ | |||
| <DotNetBuildOrchestrator>true</DotNetBuildOrchestrator> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Label="ShortStacks"> | |||
| <_OverrideTargetOS>$(OverrideTargetRid.Substring(0, $(OverrideTargetRid.LastIndexOf('-'))))</_OverrideTargetOS> | |||
| <ShortStack Condition="'$(_OverrideTargetOS)' == 'wasi'">true</ShortStack> | |||
There was a problem hiding this comment.
I wonder if the property name should indicate that this is a "runtime short stack" build.
|
Tested for android-arm64. iossimulator-x64 was working until I updated Xcode (seems Apple changed the linker and there are unrelated problems with the new one). wasi-wasm is building the runtime package, but throwing a couple of odd errors that need resolving. |
|
Let's hold this until #18409 is in. |
|
Agreed, am going to try and fix wasi & musl in the interim |
|
wasi-wasm is fixed by dotnet/runtime#98004 |
This reverts commit efb2c9e.
|
I think this regressed some of the full source-build legs: dotnet/source-build#4111. While this PR triggered a full build, it only did so for the UB legs, not for source-build:
nit: Please use squash merge unless you really want all the individual commits to show up in history. |
Tested with android-x64 and android-amd64 on Linux x64, and iossimulator-x64 on macOS ARM64.
Depends on dotnet/runtime#97725