Source built short stack support #97725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows cases where build OS and target OS differ, e.g. Android
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
directhex
added
source-build
directhex
added a commit
to directhex/installer
that referenced
this pull request
Jan 30, 2024
Tested with android-x64 and android-amd64 on Linux x64, and iossimulator-x64 on macOS ARM64. Depends on dotnet/runtime#97725
Co-authored-by: Jeremy Koritzinsky <[email protected]>
jkoritzinsky
approved these changes
Feb 1, 2024
This was referenced Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we a) always pass a value for
--osto the inner build, and b) don't pass certain flags like--allconfigurationsfor "short stack" OSes like Android which don't produce a full SDK (only runtime packs)