[release/6.0-rc1] Fix IL corruption (#2213) #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#2213) Cecil doesn't handle IL editing well. It doesn't patch scopes and branches. Added a linker-private IL processor which does this. Added tests for the IL corruption when removing branches around code which has exception handlers. I also removed now unnecessary test attribute, since in my previous change the exception handlers are now validated within the instruction stream, so no need for a second attribute to validate these. Co-authored-by: Sven Boemer <[email protected]> (cherry picked from commit e9403e2)
vitek-karas
approved these changes
Aug 20, 2021
jeffschwMSFT
approved these changes
Aug 23, 2021
agocke
changed the title
|
Merging -- we'll review this in the runtime integration PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2213 to release/6.0-rc1
Customer Impact
Fixes IL corruption issues seen in
dotnet/runtime. In many cases the invalid IL is accepted by the .NET runtime, but there may be cases where the runtime cannot JIT or produces incorrect machine code. Other runtimes, like Mono AOT, fail outright.Testing
Unit tests, manual verification.
Risk
Low. The fix is constrained to fixing up scopes and branches. Cecil already doesn't handle this properly and the IL produced by a bug in the custom processor is unlikely to be worse than the IL Cecil already produces.