Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-rc1] Update dependencies from mono/linker #58043

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 24, 2021

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 3a4da6af-00c3-4c7a-2994-08d96284e872
  • Build: 20210824.4
  • Date Produced: 8/24/2021 5:50 PM
  • Commit: edad7cbe1c568d299c196883de57fb5519fd6399
  • Branch: refs/heads/release/6.0

Issue descriptions

Backport of #2213 to release/6.0-rc1

Customer Impact
Linker will crash if types or members with DynamicallyAccessedMemberTypes are used in assembly attributes.

Testing
Unit tests

Risk
Low. The fix allows for the assembly as the source of linker diagnostics, which it didn't before.

--

Backport of #2213 to release/6.0-rc1

Customer Impact
Fixes IL corruption issues seen in dotnet/runtime. In many cases the invalid IL is accepted by the .NET runtime, but there may be cases where the runtime cannot JIT or produces incorrect machine code. Other runtimes, like Mono AOT, fail outright.

Testing
Unit tests, manual verification.

Risk
Low. The fix is constrained to fixing up scopes and branches. Cecil already doesn't handle this properly and the IL produced by a bug in the custom processor is unlikely to be worse than the IL Cecil already produces.

Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21419.1 -> To Version 6.0.100-preview.6.21424.2
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21419.1 -> To Version 6.0.100-preview.6.21424.3
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21424.3 -> To Version 6.0.100-preview.6.21424.4
@agocke agocke added the Servicing-consider Issue for next servicing release review label Aug 24, 2021
@agocke
Copy link
Member

agocke commented Aug 24, 2021

@jeffschwMSFT FYI, this contains the linker changes dotnet/linker#2220 and dotnet/linker#2219

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please get a code review and update the description with details of the issues.

@agocke
Copy link
Member

agocke commented Aug 24, 2021

@sbomer Could you double-check my work here, that this contains yours and Vitek's change?

@sbomer
Copy link
Member

sbomer commented Aug 24, 2021

Confirmed that it has those two changes - LGTM.

@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Aug 25, 2021
@ViktorHofer
Copy link
Member

Is this codeflow PR ready to be merged?

@jeffschwMSFT
Copy link
Member

There are 2 issues fixed in this change that we are going to seek approval before merging.

@ViktorHofer
Copy link
Member

There are 2 issues fixed in this change that we are going to seek approval before merging.

Just for my own education, aren't we usually approving changes in source repo's PRs and not in codeflow PRs? In this example, why didn't we seek approval for the two PRs directly in mono/linker?

@jeffschwMSFT
Copy link
Member

We don't track mono/linker and this is not a very typical flow of late issues.

@mmitche mmitche merged commit d216582 into release/6.0-rc1 Aug 26, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-release/6.0-rc1-b668a357-5454-4ff8-aad9-50addd5f8ea1 branch August 26, 2021 16:35
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-consider Issue for next servicing release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants