-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0-rc1] Update dependencies from mono/linker #58043
[release/6.0-rc1] Update dependencies from mono/linker #58043
Conversation
Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21419.1 -> To Version 6.0.100-preview.6.21424.2
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21419.1 -> To Version 6.0.100-preview.6.21424.3
Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21424.3 -> To Version 6.0.100-preview.6.21424.4
@jeffschwMSFT FYI, this contains the linker changes dotnet/linker#2220 and dotnet/linker#2219 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Please get a code review and update the description with details of the issues.
@sbomer Could you double-check my work here, that this contains yours and Vitek's change? |
Confirmed that it has those two changes - LGTM. |
Is this codeflow PR ready to be merged? |
There are 2 issues fixed in this change that we are going to seek approval before merging. |
Just for my own education, aren't we usually approving changes in source repo's PRs and not in codeflow PRs? In this example, why didn't we seek approval for the two PRs directly in mono/linker? |
We don't track mono/linker and this is not a very typical flow of late issues. |
This pull request updates the following dependencies
From https://github.com/mono/linker
Issue descriptions
Backport of #2213 to release/6.0-rc1
Customer Impact
Linker will crash if types or members with DynamicallyAccessedMemberTypes are used in assembly attributes.
Testing
Unit tests
Risk
Low. The fix allows for the assembly as the source of linker diagnostics, which it didn't before.
--
Backport of #2213 to release/6.0-rc1
Customer Impact
Fixes IL corruption issues seen in dotnet/runtime. In many cases the invalid IL is accepted by the .NET runtime, but there may be cases where the runtime cannot JIT or produces incorrect machine code. Other runtimes, like Mono AOT, fail outright.
Testing
Unit tests, manual verification.
Risk
Low. The fix is constrained to fixing up scopes and branches. Cecil already doesn't handle this properly and the IL produced by a bug in the custom processor is unlikely to be worse than the IL Cecil already produces.