Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable publishing build artifacts in PR #180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable publishing build artifacts in PR #180

wants to merge 2 commits into from
+4 −1

Conversation

carlossanlop
Copy link
Member

Fixes #164

@carlossanlop
Copy link
Member Author

carlossanlop commented Nov 14, 2024 •
edited
Loading

The artifacts are getting successfully published: https://dev.azure.com/dnceng-public/public/_build/results?buildId=870307&view=artifacts&pathAsName=false&type=publishedArtifacts

But there might be bugs:

  • There's a duplicate "Publish logs" step.
  • Artifacts_WindowsNT_Release and Artifacts_WindowsNT_Debug are only publishing the packages of the assemblies that currently have IsPackable set to true (which is only S.R.CS.Unsafe). Artifacts_Linux_Release is the only one publishing all artifacts for all assemblies.
  • In Artifacts_Linux_Release, there are artifacts being published for test projects.

Before vs After.
image

@carlossanlop
Copy link
Member Author

carlossanlop commented Nov 14, 2024 •
edited
Loading

Bug investigation:

There's a duplicate "Publish logs" step.

Seems to be expected. They are two different tasks, but the name happens to be the same.

Artifacts_WindowsNT_Release and Artifacts_WindowsNT_Debug are only publishing the packages of the assemblies that currently have IsPackable set to true (which is only S.R.CS.Unsafe). Artifacts_Linux_Release is the only one publishing all artifacts for all assemblies.

Expected. That's how we configured them. Only the 3rd one is meant for packing everything (it passes /p:IsPackable=true, the others don't).

In Artifacts_Linux_Release, there are artifacts being published for test projects.

Seems that the Pack target gets always executed for all projects.

@carlossanlop carlossanlop marked this pull request as ready for review November 14, 2024 23:50
@carlossanlop carlossanlop self-assigned this Nov 14, 2024
carlossanlop
carlossanlop commented Nov 14, 2024
View reviewed changes
eng/packaging.targets
@@ -124,6 +124,8 @@
Condition="'$(IncludeSymbols)' == 'true' and Exists('%(_RuntimeSymbolPath.Identity)')" />
</ItemGroup>
</Target>

<Target Name="Pack" Condition="'$(IsSourceProject)' != 'true'" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we were packing the test projects and uploading to the artifacts. I don't think we care about them. Do we?

If we don't care about them, then is this the right way to skip test project packiung, @ViktorHofer @ericstj?

Before:

Example: https://dev.azure.com/dnceng-public/public/_build/results?buildId=870307&view=artifacts&pathAsName=false&type=publishedArtifacts

Before

 The package Microsoft.SqlServer.TDS.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.symbols.nupkg'.
  The package Circle.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.nupkg'.
  The package Shapes.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.symbols.nupkg'.
  The package Circle.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.nupkg'.
  The package Shapes.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.symbols.nupkg'.
  The package Circle.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.nupkg'.
  The package Shapes.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.nupkg'.
  The package Shapes.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Threading.Tasks.Extensions.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Threading.Tasks.Extensions.4.6.1-ci.24564.1.symbols.nupkg'.
  The package Address.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  The package Address.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Address.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Address.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Numerics.Vectors.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Numerics.Vectors.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Xml.XPath.XmlDocument.4.7.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Xml.XPath.XmlDocument.4.7.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.Bcl.HashCode.6.0.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.Bcl.HashCode.6.0.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Buffers.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Buffers.4.6.1-ci.24564.1.symbols.nupkg'.
  The package Utf8String.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Utf8String.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Utf8String.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Net.WebSockets.WebSocketProtocol.5.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Net.WebSockets.WebSocketProtocol.5.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Memory.4.6.1-ci.24564.1.nupkg'.
  The package Microsoft.SqlServer.TDS.EndPoint.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.EndPoint.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Memory.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.EndPoint.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Data.SqlClient.4.9.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Runtime.CompilerServices.Unsafe.6.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Runtime.CompilerServices.Unsafe.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Data.SqlClient.4.9.1-ci.24564.1.symbols.nupkg'.
  The package Microsoft.SqlServer.TDS.Servers.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.Servers.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.Servers.1.0.0-ci.24564.1.symbols.nupkg'.
After:

After

  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Numerics.Vectors.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Numerics.Vectors.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Threading.Tasks.Extensions.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Threading.Tasks.Extensions.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Buffers.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Buffers.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.Bcl.HashCode.6.0.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.Bcl.HashCode.6.0.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Xml.XPath.XmlDocument.4.7.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Xml.XPath.XmlDocument.4.7.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Memory.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Memory.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Runtime.CompilerServices.Unsafe.6.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Runtime.CompilerServices.Unsafe.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Data.SqlClient.4.9.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Net.WebSockets.WebSocketProtocol.5.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Net.WebSockets.WebSocketProtocol.5.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Data.SqlClient.4.9.1-ci.24564.1.symbols.nupkg'.

@ViktorHofer
Copy link
Member

This is uploading too much. We don't want the bin folder i.e.:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

@ericstj ericstj Awaiting requested review from ericstj

At least 1 approving review is required to merge this pull request.

Assignees

@carlossanlop carlossanlop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YML should upload produced packages as pipeline artifacts
2 participants
@carlossanlop @ViktorHofer