Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable publishing build artifacts in PR #180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

Enable publishing build artifacts in PR #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8afe094
Enable publishing build artifacts in PR
carlossanlop Nov 14, 2024
78d41c3
Skip the packing target for non-source projects
carlossanlop Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/packaging.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@
Condition="'$(IncludeSymbols)' == 'true' and Exists('%(_RuntimeSymbolPath.Identity)')" />
</ItemGroup>
</Target>

<Target Name="Pack" Condition="'$(IsSourceProject)' != 'true'" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we were packing the test projects and uploading to the artifacts. I don't think we care about them. Do we?

If we don't care about them, then is this the right way to skip test project packiung, @ViktorHofer @ericstj?

Before:

Example: https://dev.azure.com/dnceng-public/public/_build/results?buildId=870307&view=artifacts&pathAsName=false&type=publishedArtifacts

Before

 The package Microsoft.SqlServer.TDS.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.symbols.nupkg'.
  The package Circle.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.nupkg'.
  The package Shapes.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.symbols.nupkg'.
  The package Circle.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.nupkg'.
  The package Shapes.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.symbols.nupkg'.
  The package Circle.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.nupkg'.
  The package Shapes.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.nupkg'.
  The package Shapes.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Circle.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Shapes.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Threading.Tasks.Extensions.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Threading.Tasks.Extensions.4.6.1-ci.24564.1.symbols.nupkg'.
  The package Address.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  The package Address.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Address.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Address.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Numerics.Vectors.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Numerics.Vectors.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Xml.XPath.XmlDocument.4.7.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Xml.XPath.XmlDocument.4.7.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.Bcl.HashCode.6.0.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.Bcl.HashCode.6.0.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Buffers.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Buffers.4.6.1-ci.24564.1.symbols.nupkg'.
  The package Utf8String.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Utf8String.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Utf8String.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Net.WebSockets.WebSocketProtocol.5.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Net.WebSockets.WebSocketProtocol.5.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Memory.4.6.1-ci.24564.1.nupkg'.
  The package Microsoft.SqlServer.TDS.EndPoint.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.EndPoint.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Memory.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.EndPoint.1.0.0-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Data.SqlClient.4.9.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Runtime.CompilerServices.Unsafe.6.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Runtime.CompilerServices.Unsafe.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Data.SqlClient.4.9.1-ci.24564.1.symbols.nupkg'.
  The package Microsoft.SqlServer.TDS.Servers.1.0.0-ci.24564.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.Servers.1.0.0-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.SqlServer.TDS.Servers.1.0.0-ci.24564.1.symbols.nupkg'.
After:

After

  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.IO.Redist.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Numerics.Vectors.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Numerics.Vectors.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Json.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Threading.Tasks.Extensions.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Threading.Tasks.Extensions.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Buffers.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Buffers.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.Bcl.HashCode.6.0.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\Microsoft.Bcl.HashCode.6.0.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Reflection.DispatchProxy.4.8.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Xml.XPath.XmlDocument.4.7.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Xml.XPath.XmlDocument.4.7.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Memory.4.6.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Memory.4.6.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Runtime.CompilerServices.Unsafe.6.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Runtime.CompilerServices.Unsafe.6.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Data.SqlClient.4.9.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Net.WebSockets.WebSocketProtocol.5.1.1-ci.24564.1.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Net.WebSockets.WebSocketProtocol.5.1.1-ci.24564.1.symbols.nupkg'.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Release\Shipping\System.Data.SqlClient.4.9.1-ci.24564.1.symbols.nupkg'.


<Target Name="ValidatePackageReadmeExists" Condition="'$(IsShipping)' == 'true' and !Exists('$(PackageReadmeFile)')">
<Error Text="$(PackageId) is a shipping package and is missing a required package README file. Add a 'PACKAGE.md' file to the source project folder." />
Expand Down
3 changes: 2 additions & 1 deletion eng/pipelines/maintenance-packages-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ stages:
parameters:
artifacts:
publish:
artifacts: false
artifacts: true
logs: true
manifests: true
enableMicrobuild: true
enablePublishUsingPipelines: true
enablePublishBuildArtifacts: true
publishAssetsImmediately: true
enablePublishTestResults: true
testResultsFormat: vstest
Expand Down