Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Label.LineHeight to Handler #368

Closed
hartez opened this issue Mar 3, 2021 · 0 comments
Closed

Port Label.LineHeight to Handler #368

hartez opened this issue Mar 3, 2021 · 0 comments
Labels
area-controls-label Label, Span

Comments

@hartez
Copy link
Contributor

hartez commented Mar 3, 2021 •
edited by Redth
Loading

Please read the Handler Property PR Guidelines for instructions on how to create and submit a PR for this issue.

Thanks for your help!
This was referenced Mar 15, 2021
Closed
Merged
hartez added a commit that referenced this issue Mar 17, 2021
@AmrAlSayed0 @hartez
Implemented LineHeight on Label (#538)
699becd 
* Implemented LineHeight on Label (#368)

* Fix-up after rebase

Co-authored-by: E.Z. Hart <[email protected]>
hartez added a commit that referenced this issue Mar 18, 2021
@AmrAlSayed0 @hartez
Implemented LineHeight on Label (#538)
e0c4403 
* Implemented LineHeight on Label (#368)

* Fix-up after rebase

Co-authored-by: E.Z. Hart <[email protected]>
hartez added a commit that referenced this issue Mar 18, 2021
@hartez @jsuarezruiz
@hevey @mattleibow @AmrAlSayed0
Handler staging (#547)
25e6476 
* TimePicker Handlers (#454)

* TimePickerHandlers

* Undo changes in sample

* Add some nullability fixes

* Fix build error

* Changes from PR feedback

* Fixed build error

* Updated tests

* Roll time picker and popup into one control

* Move 24 hour view check to handler

* Pull NSLocale -> CultureInfo code out to common property

Co-authored-by: E.Z. Hart <[email protected]>
Co-authored-by: E.Z. Hart <[email protected]>

* CheckBoxHandlers (#432)

* Rename ICheck -> ICheckBox, remove Color stuff (to be replaced with Brush
later), fix DeviceTests

* Implement CharacterSpacing property in EditorHandlers (#516)

* Fix broken test and incorrect CharacterSpacing on iOS

* Implement HorizontalTextAlignment property in EntryHandlers (#524)

* Better text on example

* Remove IView from ITextAlignment

* Remove IView from IPlaceholder

* Implement IsTextPredictionEnabled property on Editor (#515)

* Initial implementation

* Added Tests

* Added PortHandler Attributes

* Added Tests

* Handle turning text prediction back on

Co-authored-by: E.Z. Hart <[email protected]>

* Implement ReturnType property in EntryHandlers (#518)

* Implement CharacterSpacing property in SearchBarHandlers (#494)

* Implement CharacterSpacing in SearchBarHandlers

* Tests failing because of static

* Rounding for Android

* Fix iOS test

* There! No magic numbers!

* Fix rebase issuse and make SearchBar stuff work on iOS

Co-authored-by: Matthew Leibowitz <[email protected]>
Co-authored-by: E.Z. Hart <[email protected]>

* Stepper Handlers (#517)

* StepperHandlers

* Fixed Stepper handler broken tests

* Remove duplicate searchbar

* Add IStepper interface

Co-authored-by: E.Z. Hart <[email protected]>

* IStepper.Increment -> IStepper.Step

* Picker Handlers (#433)

* PickerHandlers

* Nullability fixes

* Updated Picker device tests

* New things in the tests!

* Removed unnecessary Android Api level validation

* Added Picker Items null validation in iOS PickerHandler

* Moved Picker Handler tests between different classes

* Renamed NativePicker to MauiPicker

* Removed unused code from iOS PickerExtensions

* Fix build error

* Fix build error

* Remove duplicate class

Co-authored-by: Matthew Leibowitz <[email protected]>
Co-authored-by: E.Z. Hart <[email protected]>

* ActivityIndicator Handlers (#417)

* ActivityIndicatorHandler

* Register IActivityIndicator

* Add comments to IActivityIndicator

* Fix build error

* Implement Font properties in SearchBarHandlers (#533)

* Speed up PR builds (#510)

Reduce the jobs and use the new pools

* implement Font properties in SearchBarHandlers

* Fix rebase issues

Co-authored-by: Matthew Leibowitz <[email protected]>
Co-authored-by: E.Z. Hart <[email protected]>

* Implemented LineHeight on Label (#538)

* Implemented LineHeight on Label (#368)

* Fix-up after rebase

Co-authored-by: E.Z. Hart <[email protected]>

* Fix broken label tests; add some missing label tests; attributed string cleanup

* Consolidate and rename extension method classes

* Fix class names and de-duplicate methods

* Centralize time extensions

* Fix mapping

Co-authored-by: Javier Suárez <[email protected]>
Co-authored-by: Glenn Hevey <[email protected]>
Co-authored-by: Matthew Leibowitz <[email protected]>
Co-authored-by: Amr <[email protected]>
@hartez hartez closed this as completed Mar 18, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2022
@samhouts samhouts added the area-controls-label Label, Span label Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-controls-label Label, Span
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hartez @samhouts