Handler staging #547
Merged
Handler staging #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hartez
commented
Mar 18, 2021
hartez
commented
- TimePicker handlers (TimePicker Handlers #454)
- CheckBox handlers (CheckBox Handlers #432)
- Stepper (Stepper Handlers #517)
- Picker (Picker Handlers #433)
- ActivityIndicator (ActivityIndicator Handlers #417)
- Editor.CharacterSpacing (Implement CharacterSpacing property in EditorHandlers #516)
- Entry.HorizontalTextAlignment (Implement HorizontalTextAlignment property in EntryHandlers #524)
- Editor.IsTextPredictionEnabled (Implement IsTextPredictionEnabled property on Editor #515)
- Entry.ReturnType (Implement ReturnType property in EntryHandlers #518)
- SearchBar.CharacterSpacing (Implement CharacterSpacing property in SearchBarHandlers #494)
- SearchBar.Font (Implement Font properties in SearchBarHandlers #533)
- Label.LineHeight (Implemented LineHeight on Label #538)
* TimePickerHandlers * Undo changes in sample * Add some nullability fixes * Fix build error * Changes from PR feedback * Fixed build error * Updated tests * Roll time picker and popup into one control * Move 24 hour view check to handler * Pull NSLocale -> CultureInfo code out to common property Co-authored-by: E.Z. Hart <[email protected]> Co-authored-by: E.Z. Hart <[email protected]>
…rush later), fix DeviceTests
* Initial implementation * Added Tests * Added PortHandler Attributes * Added Tests * Handle turning text prediction back on Co-authored-by: E.Z. Hart <[email protected]>
* Implement CharacterSpacing in SearchBarHandlers * Tests failing because of static * Rounding for Android * Fix iOS test * There! No magic numbers! * Fix rebase issuse and make SearchBar stuff work on iOS Co-authored-by: Matthew Leibowitz <[email protected]> Co-authored-by: E.Z. Hart <[email protected]>
* StepperHandlers * Fixed Stepper handler broken tests * Remove duplicate searchbar * Add IStepper interface Co-authored-by: E.Z. Hart <[email protected]>
* PickerHandlers * Nullability fixes * Updated Picker device tests * New things in the tests! * Removed unnecessary Android Api level validation * Added Picker Items null validation in iOS PickerHandler * Moved Picker Handler tests between different classes * Renamed NativePicker to MauiPicker * Removed unused code from iOS PickerExtensions * Fix build error * Fix build error * Remove duplicate class Co-authored-by: Matthew Leibowitz <[email protected]> Co-authored-by: E.Z. Hart <[email protected]>
* ActivityIndicatorHandler * Register IActivityIndicator * Add comments to IActivityIndicator * Fix build error
* Speed up PR builds (#510) Reduce the jobs and use the new pools * implement Font properties in SearchBarHandlers * Fix rebase issues Co-authored-by: Matthew Leibowitz <[email protected]> Co-authored-by: E.Z. Hart <[email protected]>
* Implemented LineHeight on Label (#368) * Fix-up after rebase Co-authored-by: E.Z. Hart <[email protected]>
samhouts
added
legacy-area-controls
samhouts
added
area-controls-checkbox
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.