Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add animated GIF support for Image on iOS #19411

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add animated GIF support for Image on iOS #19411

merged 1 commit into from
Feb 16, 2024

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Dec 13, 2023 •
edited
Loading

Description of Change

This is an alternate take on #17207 using the ideas from FFImageLoading.

Issues Fixed

Fixes #866

Depends on:

@mattleibow mattleibow requested a review from a team as a code owner December 13, 2023 21:45
@Eilon Eilon added the area-image Image loading, sources, caching label Dec 13, 2023
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Jan 8, 2024
@mattleibow mattleibow mentioned this pull request Jan 19, 2024
Merged
@mattleibow mattleibow force-pushed the dev/gif-investigations branch 2 times, most recently from c439ba6 to 11b870c Compare January 19, 2024 20:26
@github-actions github-actions bot force-pushed the dev/gif-investigations branch 2 times, most recently from 3a81b58 to 12851a6 Compare January 23, 2024 15:23
@mattleibow mattleibow force-pushed the dev/gif-investigations branch 2 times, most recently from 114b909 to 3c0f9d9 Compare January 23, 2024 19:00
@mattleibow
Copy link
Member Author

/rebase

@mattleibow mattleibow changed the title Add animated GIF support for Image Add animated GIF support for Image on iOS Jan 25, 2024
@mattleibow mattleibow added this to the .NET 8 SR3 milestone Jan 26, 2024
@samhouts samhouts added platform/iOS 🍎 and removed stale Indicates a stale issue/pr and will be closed soon labels Feb 1, 2024
@tj-devel709
Copy link
Member

tj-devel709 commented Feb 15, 2024 •
edited
Loading

Do you expect that the ImageButton version with the gif should be playing as well?
It looks good in the ImagePage though!

GifSample.mov

@PureWeen PureWeen mentioned this pull request Feb 15, 2024
Closed
@PureWeen
Copy link
Member

Failing tests unrelated

@PureWeen PureWeen merged commit e15cf82 into main Feb 16, 2024
37 of 49 checks passed
@PureWeen PureWeen deleted the dev/gif-investigations branch February 16, 2024 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@Eilon Eilon added area-controls-image Image control and removed area-image Image loading, sources, caching labels May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-controls-image Image control fixed-in-8.0.10 fixed-in-9.0.0-preview.2.10247 fixed-in-9.0.0-preview.2.10293 platform/iOS 🍎
Projects
None yet
Milestone
.NET 8 SR3
Development

Successfully merging this pull request may close these issues.

[Bug] Animated GIF files do not play on iOS/macOS
5 participants
@mattleibow @tj-devel709 @PureWeen @Eilon @samhouts