[WinUI] Fix gif animation initial state #20169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
changed the title
ghost
added
the
legacy-area-controls
mattleibow
force-pushed
the
dev/winui-gif-init
branch
from
f12aa6b
to
7df52a4
Compare
mattleibow
commented
Jan 26, 2024
| public partial class ImageHandler : ViewHandler<IImage, Image> | ||
| public partial class ImageHandler : ViewHandler<IImage, WImage> |
There was a problem hiding this comment.
Image === WImage, just using the type alias as it got confusing.
mattleibow
commented
Jan 26, 2024
Comment on lines
-45
to
-46
| if (destinationContext is WImage imageView) | ||
| imageView.UpdateIsAnimationPlaying(image); |
There was a problem hiding this comment.
This did nothing as the image is only animatable after it is decoded - which is after it is on-screen.
This was referenced Jan 26, 2024
jsuarezruiz
approved these changes
Feb 2, 2024
PureWeen
pushed a commit
that referenced
this pull request
Feb 8, 2024
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Animated GIF on WinUI are not correctly respecting the IsAnimationPlaying because the actual image is animated, not the view. However, the image has to actually be loaded and on-screen before we can start/stop playing.
This PR waits for the image to be fully loaded and presented before handling the animation.
This PR needs:
Based on the work in: