Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle access to vssps for PerfStar #10366

Conversation

YuliiaKovalova
Copy link
Member

Fixes:

Issues with access to msbuild.exe bit for perfstar run.
In order to secure that, a new SP was created and added to the corresponding organization.

Validation:

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9874247&view=logs&j=063f674e-38db-59b9-8dc6-bda499493784&t=d2d8d882-24a4-5280-d5d8-e137cda2c3ba

@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner July 12, 2024 18:04
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that failure is one where we need to refactor to deal with #10299?

@YuliiaKovalova
Copy link
Member Author

I assume that failure is one where we need to refactor to deal with #10299?

I am not sure it's related.
Hopefully, @AR-May has more insights :)

.exp-insertions.yml Outdated Show resolved Hide resolved
@AR-May
Copy link
Member

AR-May commented Jul 15, 2024

I assume that failure is one where we need to refactor to deal with #10299?

I am not sure it's related. Hopefully, @AR-May has more insights :)

No, this is unrelated. This is for being able to run msbuild.exe in perf tests.

@YuliiaKovalova YuliiaKovalova enabled auto-merge (squash) July 15, 2024 09:13
@YuliiaKovalova YuliiaKovalova merged commit 977d5cc into dotnet:main Jul 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants