Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the build template #10299

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Update the build template #10299

merged 1 commit into from
Jun 28, 2024

Conversation

f-alizada
Copy link
Contributor

Fixes #10229

Context

The builds started to receive warnings.

Changes Made

Update the build and what we are publishing in artifacts:

  • Removed the bin folder completely.
  • Removed the file that is not generated by msbuild steps, however was not signed.
  • Add item to sign after build.

Testing

Tested on experimental branch: exp/f-alizada/code-sign-validation

@f-alizada f-alizada requested a review from a team as a code owner June 27, 2024 08:09
@f-alizada f-alizada merged commit 671434e into dotnet:main Jun 28, 2024
10 checks passed
@rainersigwald rainersigwald mentioned this pull request Jul 12, 2024
Merged
@f-alizada f-alizada mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maridematte maridematte maridematte approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Kitten] Fix pipeline warnings
3 participants
@f-alizada @maridematte @YuliiaKovalova